search

vslavik / bakefile

Bakefile makefiles generator
http://bakefile.org
MIT License
142 stars 20 forks source link

Add MSVS 2019 toolset support #118

Closed vadz closed 4 years ago

vadz commented 4 years ago

This is identical to the changes done for adding MSVS 2017, except that it combines the changes of 1ce39c7f87fc4b33929fec6f88aab865381f5bb5 and 42a8f058f643debd9666c0731e69a49646d59ce7 into a single commit.

vadz commented 4 years ago

BTW, I don't like duplicating everything for each new version of MSVS, of course, and I think of trying to replace them all with just a single msbuild backend, perhaps. But perhaps it would be better to wait until MSVS 2020 or whatever is released to see how long are they going to preserve compatibility between them and, in any case, I need a short-term solution right now and adding this shouldn't really do any harm.

vslavik commented 4 years ago

Seems fine to me.

BTW, I don't like duplicating everything for each new version of MSVS

In bakefile implementation or uses? IIRC the motivation for this came from (wx's) desire to have the project files as they would be created by MSVS, hence the need to cover small differences.

I do agree it would be better to generate universal projects, and FWIW I don't think there's any point in waiting for the next MSVS iteration — it seems rather stable in these regards in the past few years, and the risk of radical changes is IMHO minimal.

vadz commented 4 years ago

I've finally merged this, as I think it can still be useful for the projects targeting MSVS 2019 and nothing else, but I've also created the other PR with a better solution for the projects that should be compilable with different MSVS versions.