Do not try to rescale recent file icon when it cannot be loaded

vslavik / poedit

Translations editor for Mac, Windows and Unix

https://poedit.net

MIT License

1.71k stars 274 forks source link

Closed super7ramp closed 2 years ago

super7ramp commented 2 years ago

Recent file icon loading may fail e.g. because of missing read permission or other packaging issue.

Icon rescale code introduced by 5fc8d6c did not foresee this possibility.

Add a condition to prevent it from manipulating a non-ok icon.

This prevents assertion error although icon loading failure will still lead to an error message showed to user.

See #758.

vslavik commented 2 years ago

Thanks for the fix! I should have caught this myself in review, but completely missed it too.