Closed LeonarddeR closed 1 year ago
@vslavik Regarding code style, is there a style guide somewhere? I started with visual studio, then realized overall code style is very different from the current style of poedit.
Thanks!
@vslavik Regarding code style, is there a style guide somewhere?
Just mimic the surrounding code... I'm guessing you ask because of class naming and the somewhat schizophrenic CamelCase vs cxx_standard_like? I started switching to the latter in mostly non-GUI or abstracted code, but not sure it was such a bright idea, as it seems weird around wxWidgets' GUI code...
This looks good to me, I just pushed a removal of unneeded dynamic_cast
in 4d334d127e71f4847a9fa7213395fb604832c7ee.
There is no reliable way for screen reader users to find out the fuzzy (needs work) status. After some research, the most likely cause is as follows:
I forgot to address this: that does sound plausible, thanks for making sense of the situation.
Merged now, thanks again!
Fixes #693
Issue summary
There is no reliable way for screen reader users to find out the fuzzy (needs work) status. After some research, the most likely cause is as follows:
Solution
Implement a wxAccessible subclass as outlined in #696
Testing performed
Executed from source, ensured that the needs work button is reported as check box and that toggling the button is properly reported by the NVDA screen reader.