search

vslavik / poedit

Translations editor for Mac, Windows and Unix
https://poedit.net
MIT License
1.77k stars 275 forks source link

Not all missing placeholders reported? #848

Closed kkmuffme closed 3 months ago

kkmuffme commented 3 months ago

3.4.4

original:

Welcome to %s portal

translated:

Willkommen bei % Portal

It should a) report an error that it's missing the placeholder in the translation b) generally report errors when a single % is used, as in PHP 8 this will lead to a notice https://3v4l.org/En0lQ and it would be great if this could be caught early

vslavik commented 3 months ago

Please provide an actual reproduction case, i.e. all involved files + steps to perform with them.

kkmuffme commented 3 months ago

Start with PHP:

<?php

_e( 'Welcome to %s portal', 'foo' );

...

in the de_DE.po translate the string as Willkommen bei % Portal

vslavik commented 3 months ago

Again, can you please actually provide an actual reproduction case, i.e. all involved files + steps to perform with them? Not some censored half-quoted files, and vague hand-waving about what you did, provide actual files to check your settings and outputs, and detailed steps you did.

vslavik commented 3 months ago

As expected, Poedit does in fact show an error in this case. xgettext does correctly extract the string from the provided PHP snippet and flags it asphp-format, and Poedit reports it:

Screenshot 2024-07-04 at 11 45 11

When developers ask you to be precise, it's not to harass you, it's because you really don't describe the circumstances fully and they can't do much without full information. Going incommunicado in response only wastes everybody's time in the end.

Closing as not reproducible, absent non-vague reproduction instructions form the OP.