search

vslavik / winsparkle

App update framework for Windows, inspired by Sparkle for macOS
http://winsparkle.org
Other
1.31k stars 267 forks source link

Added explanation of nuget tools #149

Closed johnwbyrd closed 7 years ago

johnwbyrd commented 7 years ago

In order to build this library from source, you need to use nuget to install GetText.Tools via packages.xml. If you don't have nuget installed, you're in for some pain. This readme change clarifies this.

GitCop commented 7 years ago

Thanks for contributing! Unfortunately there were the following style issues with your Pull Request:

Please follow git commit message guidelines (you can use git push -f to update this PR).

This message was auto-generated by https://gitcop.com

johnwbyrd commented 7 years ago

Oh fuck off gitcop. @vslavik , you can apply the change as you see fit. I wasted an hour figuring out this small detail about your software.

vslavik commented 7 years ago

Dear @johnwbyrd,

just because GitCop is a bot doesn't mean you should be an abusive a-hole towards the poor lad.

You know what I have "wasted" not an hour, but years, doing? Writing WinSparkle so that you can use it for free and save tens of hours of your oh-so-precious time that you don't have to spend writing an equivalent. Whether you spend an hour or an hour and five minutes giving at least a little back seems immaterial — you're still tens of hours ahead. When you show your appreciates with nice phrases like "fuck off", you come off more than a bit entitled and rude.

The things GitCop asks for are the absolute barest minimum of reasonable git hygiene — like asking you to wash your hands. It may make no difference to a drive-by cowboy with attitude, but things like consistent reasonable commits matter to people that will be maintaining the codebase for years in the future.

In addition to the problems GitCop flagged, there are more serious one, in increasing order of seriousness:

  1. There's some crazy merge commit in there that makes no sense and shouldn't be there.
  2. There's no packages.xml and so the given commands don't even work.
  3. Most importantly, none of this should actually be needed normally (which, coincidentally, is why the README didn't say so) — NuGet is bundled with Visual Studio since 2012 and restoring packages works out of the box in any reasonably modern version of VS.

I don't know what's going on in #138 (which claims VS2015), but the need to manually install deps is not it. Perhaps it's some limited trimmed down install?

johnwbyrd commented 7 years ago

You're right, I was referring to packages.config, not packages.xml.

The command line version of nuget is not installed on Visual Studio 2015. msgfmt does not exist in your release and needs to be installed via nuget, automatically or no, before the software will compile.

vslavik commented 7 years ago

The command line version of nuget is not installed on Visual Studio 2015

VS2015 installs nuget packages automatically upon first build, without CLI tools.