vslavik / winsparkle

App update framework for Windows, inspired by Sparkle for macOS
http://winsparkle.org
Other
1.31k stars 267 forks source link

Multiple check for updates calls when existing window is open does not load release notes #155

Closed johnmurphy01 closed 6 years ago

johnmurphy01 commented 6 years ago

When a check for updates dialog UI is already open and subsequent check for updates occur while the dialog UI is still open results in the release notes text not loading. This is in the case that release notes are loaded from the <description> tag.

Steps to reproduce:

First update check: image

Next update check with the WinSparkle window still open: image

I believe this is due to the web browser already being loaded and so there is some initialization that needs to take place but is getting skipped. I will make my proposed modification and submit a PR.

johnmurphy01 commented 6 years ago

https://github.com/vslavik/winsparkle/pull/156

Thanks!

vslavik commented 6 years ago

"Backporting" important update from #156 (feel free to create PRs right away without corresponding issue, BTW):

Added Note: This issue does appear to only affect release notes that are loaded using the description tag. Loading release notes using a url does not appear to have this issue.