search

vslavik / winsparkle

App update framework for Windows, inspired by Sparkle for macOS
http://winsparkle.org
Other
1.31k stars 267 forks source link

Added callback to handle zip files in app instead of expecting an installer to run #220

Closed patrickkidd closed 4 years ago

patrickkidd commented 4 years ago

WinSparkle expects the download to be an executable installer. This is a problem when the download is a zip file and merely contains an updated copy of the executable (i.e. for statically linked executables with no dependencies or installer). This adds a callback so that zip files can be handled in the app.

This pull request is not very clean. It doesn't add anything to the api but does expose the new function in the api. Maybe you can think of a better way to add this cleanly. But there should be some way to handle download payloads that are not installers.

patrickkidd commented 4 years ago

Thanks for your thorough comments. My apologies for everything after the first commit. This is my first pull request and I did not know that they would make it into it. They were more for my own project.

At any rate, maybe if we can sort out the concepts here then I can submit a proper pull request that you can merge directly instead of just as a hypothetical suggestion for a new feature.