vslavik / winsparkle

App update framework for Windows, inspired by Sparkle for macOS
http://winsparkle.org
Other
1.31k stars 267 forks source link

The update permission request dialog is centered and moved to the top #264

Closed zvm67 closed 5 days ago

zvm67 commented 1 year ago

The AskPermissionDialog dialog for requesting permission becomes more visible if it is placed in the center and at the top of the main program window. Also .aps and .bak files added to ignore for git

vslavik commented 1 year ago

Also

Please don't do that. One commit should do one thing and should be described well

Also .aps and .bak files added to ignore for git

Where do you see any such files and what creates them?

zvm67 commented 1 year ago

Please don't do that. One commit should do one thing and should be described well

I apologize for two changes in one request. I just didn't want to make an additional request because of two lines.

Where do you see any such files and what creates them?

Files with the ".bak" extension are created by many text editors and utilities (for example, comparison utilities) for backup files. Files with the ".aps" extension are created by Visual Studio as a binary representation of resources, and in fact, are cache files for the development environment. Files with these extensions are included in the ".gitignore" file that Visual Studio produces by default.

vslavik commented 5 days ago

Thanks, merged!

(I omitted the .gitignore changes, because they are unrelated: if you use an editor that uses .bak files, you should put it into your personal exclude list, and WinSparkle's use of .rc files doesn't produce .aps)