search

vslavik / winsparkle

App update framework for Windows, inspired by Sparkle for macOS
http://winsparkle.org
Other
1.31k stars 267 forks source link

Correct closing of NODE_ITEM #280

Closed i-n-g-o closed 3 weeks ago

i-n-g-o commented 1 month ago

When OnEndElement(...) is called ctxt.in_item is still > 0. Therefore checking if the closing node is NODE_ITEM needs to happen inside that conditional block to decrease ctxt.in_item and possibly stop parsing.

vslavik commented 1 month ago

I'm sorry, but even after several re-readings, I don't understand why you want to make the change. The commit message explains what the change is (something the code already answers), but not why.

Can you please explain what is handled incorrectly and provide an example feed content that demonstrates it? TIA!

i-n-g-o commented 1 month ago

As far as I can see the code to preliminary stop parsing can never be called. It seemed not to be intended. That is why I proposed this PR. Maybe I am missing something and the original code is perfectly fine - in that case this PR of course can be discarded.

vslavik commented 3 weeks ago

No, you're right, I just couldn't understand what you were saying, because that bug was so absurd it didn't register... Sorry for being slow!