vslinko / obsidian-outliner

Work with your lists like in Workflowy or RoamResearch
MIT License
1.03k stars 60 forks source link

[BUG] Drag-and-drop is no longer working in [4.7.1] #444

Open vojtanethio opened 1 year ago

vojtanethio commented 1 year ago

Describe the bug

After update from [4.6.7] to [4.7.1] drag and drop is no longer working, before update, it was working.

here is the log: obsidian.md-1684173904365.log

To Reproduce Steps to reproduce the behavior:

  1. click and drag block of text to different place
  2. nothing happens

Expected behavior block is moved after dragging it to different position

Environment (please complete the following information):

vslinko commented 1 year ago

@vojtanethio Thanks for the feedback. It seems from the logs that there is something wrong with the identification of the lists. Could you please provide an example file that contains the issue.

vojtanethio commented 1 year ago

It does this with make.md plugin when I put sticker/emoji in header and on the first line it have problem even without putting emoji in the header.

I recorded the behaviour here: https://youtu.be/FvZANh1LZvg

obsidian.md-1684487694350.log

vojtanethio commented 1 year ago

443 I see some similarities here, plugins that introduce extra things in the header cause problems.

matyasmatta commented 1 year ago

In my files, I have tags and vertical lines in the header by template and it also breaks Drag&Drop.

ctesha commented 1 year ago

My issue is the same, and I consider my template also modified the header. I overwrited the plugin with [4.6.7] version and the drag function worked well.

mariomui commented 1 year ago

i dont have anything and it doesn't work on my vaults. Drag and Drop drag does not register.

toreforl commented 1 year ago

I have 4.8.0. Drag and drop is only working when I'm in "Source mode". Not working in Live Preview.

Mikeross373 commented 1 year ago

I have 4.8.0. Drag and drop is not working neither in Source Mode nor Live Preview. Can't move anywhere.

AND I found the reason. It's because the new property core function.

DxYz1 commented 1 year ago

I'm also experiencing the same issue with the drag n' drop feature. It not longer works. I'm currently running version 1.4.3 of Obsidian (insider version) and version 4.8.0 of Outliner on MacOS Ventura 13.4.1. Here's an output of the error from the developer tools: DragAndDrop.ts:434 Uncaught TypeError: Cannot read properties of null (reading 'left') at DragAndDropState.calculateLeftPadding (DragAndDrop.ts:434:52) at new DragAndDropState (DragAndDrop.ts:327:10) at DragAndDrop.startDragging (DragAndDrop.ts:161:19) at DragAndDrop.handleMouseMove (DragAndDrop.ts:131:12)

Rhydderch commented 1 year ago

I have 4.8.0. Drag and drop is not working neither in Source Mode nor Live Preview. Can't move anywhere.

AND I found the reason. It's because the new property core function.

I'm still having this bug. Any updates for a potential new version that fixes this 🙏? @vslinko

mariomui commented 1 year ago

It's a pretty big problem now. I fixed it on my branch but the recent to updates to obsidian have broken even those, well at least for transferring billeted embedded content.

Michael679089 commented 11 months ago

I think i found the issue to the problem. The properties part of Obsidian is somehow disabling the drag and drop feature of Outliner.

https://github.com/vslinko/obsidian-outliner/assets/90962435/18126dc7-7e8d-4c16-96b5-943d92966613

johnthepleasant commented 11 months ago

Confirming as well that drag and drop works on notes with no properties, and does not work on notes with properties.

candideu commented 7 months ago

Discussion of solutions: https://github.com/vslinko/obsidian-outliner/issues/506#issuecomment-2052148233