search

vsoch / docsy-jekyll

A Jekyll version of the beautiful Docsy!
https://vsoch.github.io/docsy-jekyll/
Apache License 2.0
199 stars 142 forks source link

Sidebar inner link are visible always #21

Closed gunhansancar closed 4 years ago

gunhansancar commented 4 years ago

The inner(child) links inside the sidebar(left one) are always visible.

They would be ideally hidden if the parent is not selected ie https://example.docsy.dev/docs/tasks/ It only shows the inner link under the selected page and hide the rest

E.g. https://example.docsy.dev/docs/concepts/ Here all the others are hidden since no child page is linked

So the expected behaviour is show child links only for the selected parent on the left sidebar. Also in the original if the very top level is selected (documentation) it shows everything again.

vsoch commented 4 years ago

It looks like we need to have a "collapse" class on the link when it's closed. I don't have any quick ideas for how to accomplish this (and I find it nice to have the links showing, likely why I didn't jump on fixing it) but if you'd like to take a shot I'd be happy to review a PR! Otherwise I'll put a help wanted on this issue. Thanks for reporting it!