FreeGenes still on title page - Githubissues

vsoch / freegenes

FreeGenes BioNode with Django

https://vsoch.github.io/freegenes/

Mozilla Public License 2.0

2 stars 4 forks source link

FreeGenes still on title page #136

Closed Koeng101 closed 4 years ago

Koeng101 commented 4 years ago

Describe the bug When app is started, (or on live app, freegenes.dev), the landing page still has "FreeGenes" on it.

To Reproduce Visit freegenes.dev or start a local docker cotnainer

Expected behavior For "FreeGenes" to be replaced with "Bionet Server".

It may be even better to have a more generic landing page that is configurable from wherever the app is deployed.

If applicable, add versions and screenshots to help explain your problem.

vsoch commented 4 years ago

How do you propose parsing that? Notice that there are two spans to handle the capitalization and coloring. We can't anticipate what the lab will have in advance, so either we have to hard code something or just remove the two toned colors.

Koeng101 commented 4 years ago

I think easiest will removing two toned colors, even though it does fit FreeGenes quite nicely

vsoch commented 4 years ago

Which color would you like to keep?

Koeng101 commented 4 years ago

The yellow, I think.

vsoch commented 4 years ago

I think I agree! Let me test this locally. I saw one more FreeGenes in the about too, I'll do another grep to check again.

vsoch commented 4 years ago

Koeng101 commented 4 years ago

Awesome!

vsoch commented 4 years ago

All set https://github.com/vsoch/freegenes/commit/175816dd84fd639f0252d6d8100721d859801698