vsoch / freegenes

FreeGenes BioNode with Django
https://vsoch.github.io/freegenes/
Mozilla Public License 2.0
2 stars 4 forks source link

Final week line edits #153

Closed Koeng101 closed 4 years ago

Koeng101 commented 4 years ago

Now that most of the "Features" required are approximately done, we're on the final stretch of "line edits" (small improvements that shouldn't take much code itself). If any of these things will take a lot of effort, let's 86 it - each one of these things should mostly be removing some html elements or adding another link.

The basic idea is that we want going from Search -> Order to be very easy and obvious. Right now, there is no obvious way to go from searching to ordering without previous knowledge of the structure of the site.

We're going to meet again on Wednesday to get one more iteration in before meeting on Friday, so may add some things then (if that is alright)

vsoch commented 4 years ago
Koeng101 commented 4 years ago

Allow "get" commands on API for all plates, wells, samples, parts, and collections

My bad for not being clear, I should have said:

'Allow "get" commands on API for all plates, wells, samples, parts, and collections' for any unlogged user (completely open access)

vsoch commented 4 years ago

okay going to add some screenshots here to keep a record of changes (to be integrated)

Add to cart button added to distribution page (note that a regular user doesn't see the edit button, that's admin/staff only) image

Warning about parts search image

Removing 1 of 6 from part details view

image

Gotcha on the permissions.

vsoch commented 4 years ago

@Koeng101 I've done all of the changes above, with two boxes left unchecked, details:

Koeng101 commented 4 years ago

I removed the part.status from tables and import, but not from the model in the database

Sounds good

Could you clarify how "Get this part" fits into the part page? If you are referring to the Part details page, that would be the page linked to from the search, so it wouldn't be logical to link to itself. The node doesn't have a way to order a single part, so it's not clear what we would link to here.

We just want there to be a link within the Part page to a distribution that you could actually get.

vsoch commented 4 years ago

Ah understood, then how about a link to each of the distributions the part is available in? It should be the case that each part belongs to one, but we can't always be sure this will forever be true. What I'll do is add a Distributions row and then link (with the name of the distribution) to get it.

Koeng101 commented 4 years ago

Ah understood, then how about a link to each of the distributions the part is available in?

Perfect!

vsoch commented 4 years ago

And this is going to be a pretty convoluted query to go from Part -> Sample -> Well -> Plate -> PlateSet -> Distribution, but it's only for one part so it shouldn't be terribly slow. This wouldn't work for a batch query.

Koeng101 commented 4 years ago

I'm not sure if this is setup, but couldn't most of this stuff just be cached? Shouldn't be terribly slow if it's cached initially

vsoch commented 4 years ago

Django front end views would be cached I think.

vsoch commented 4 years ago

okay all set! Since we can check off the other two boxes, I'm going to close the issue.

Tomorrow I'm leaving for Supercomputing, so if you get issues in early (before 10:30am likely) I'll be able to work on them, otherwise I'll be back later evening / likely Wednesday.