search

vsoch / freegenes

FreeGenes BioNode with Django
https://vsoch.github.io/freegenes/
Mozilla Public License 2.0
2 stars 4 forks source link

Improvements to Map #43

Closed vsoch closed 5 years ago

vsoch commented 5 years ago

This isn't a priority, but we discussed a few (future) improvements to make to the map:

shea256 commented 5 years ago

Hey @vsoch, I Just submitted a PR (#60) for map improvements.

In this PR you'll find an integration with a new map library called Mapbox. This allows us to support zooming and some other very cool UI features.

You'll also notice that if you click on an order icon, a popup is displayed with a title and description for the order. This works well if we want to show individual orders and we don't have too many.

That said, judging from the way you designed the first map, it looks like you want to plan for tons of orders and show larger bubbles based on the number of orders in a given area.

Is that still the plan? Are ways of displaying the map data more flexible? Are there other alternatives we should consider?

As far as filtering by order type, that is doable as well. But before moving forward on this, I wanted to ask about the JSON that is generated to be used for the map.

How would you like to surface the order type in that data?

vsoch commented 5 years ago

Thanks @shea256 - I get notified for all comments / PRs / issues so you don't need to notify me in the issue (but it's good practice to say something like "This will close #43" in the PR so it's automatically closed. Let's continue discussion in the PR - I just thought of something important I forgot to mention.

shea256 commented 5 years ago

Thanks @shea256 - I get notified for all comments / PRs / issues so you don't need to notify me in the issue (but it's good practice to say something like "This will close #43" in the PR so it's automatically closed.

Sure thing! I actually did that in the initial comment here:

https://github.com/vsoch/freegenes/pull/60#issue-321091841

But I just added it into the title as well.

Let's continue discussion in the PR - I just thought of something important I forgot to mention.

And sounds good, thank you.

vsoch commented 5 years ago

https://freegenes.dev/map/orders