vsoch / freegenes

FreeGenes BioNode with Django
https://vsoch.github.io/freegenes/
Mozilla Public License 2.0
2 stars 4 forks source link

Download csv of distribution #66

Closed Russell-Tran closed 5 years ago

Russell-Tran commented 5 years ago

The problem is that when you download a csv of the distribution, it shows 3000 genes when it should show ~ 40. Thanks :)

vsoch commented 5 years ago

Could you please link to the page with the download link? Thanks!

vsoch commented 5 years ago

Hey @Russell-Tran I'm testing this out, and I think what you are seeing is correct. You aren't seeing genes, you are seeling wells. For example, for the open enzype 1 distribution we have a total of 1 platesets.

dist.platesets.all()                                                                                                                                                
Out[5]: <QuerySet [<PlateSet:OpenEnzyme,72>]>

The plateset has 72 plates, as you can see. For each plate, we can sum up the wells:

plateset = dist.platesets.all()[0]
wells = 0                                                                                                                                                           

for plate in plateset.plates.all(): 
    wells += plate.wells.count() 

and we get the exact number of rows in that sheet.

wells
# 3024

This is how I believe @Koeng101 requested the implemented, let me know if something isn't clear or some different endpoint is desired.

vsoch commented 5 years ago

If there is some additional export that you think should be provided in the interface, and you are not able to use the freegenes API client to get it, I'd be happy to have some discussion here about what you are looking for, confirm with @Koeng101, and add (likely) tomorrow.

Russell-Tran commented 5 years ago

Oh thanks for clearing that up! I was hanging out with Keoni at SBB and we were messing around on the website and he told me to put that lol


From: Vanessasaurus notifications@github.com Sent: Thursday, October 3, 2019 2:55:53 PM To: vsoch/freegenes freegenes@noreply.github.com Cc: Russell Tran tranrl@stanford.edu; Mention mention@noreply.github.com Subject: Re: [vsoch/freegenes] Download csv of distribution (#66)

If there is some additional export that you think should be provided in the interface, and you are not able to use the freegenes API clienthttps://vsoch.github.io/freegenes-python/docs/getting-started/python-client to get it, I'd be happy to have some discussion here about what you are looking for, confirm with @Koeng101https://github.com/Koeng101, and add (likely) tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/vsoch/freegenes/issues/66?email_source=notifications&email_token=AK6HPWHEEQFTYRPE7C5TVYTQMZS6TA5CNFSM4I5IJHGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAJW7NQ#issuecomment-538144694, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK6HPWDPHTJ5HHXJFHS6WD3QMZS6TANCNFSM4I5IJHGA.

vsoch commented 5 years ago

You can see the original discussion here -> https://github.com/vsoch/freegenes/issues/16 the request was for plates and wells, so possibly he was thinking of adding another export?

vsoch commented 5 years ago

Closing issue here - if there is some new endpoint desired, Keoni will let me know!