search

vsoch / gridtest

grid parameters and testing for Python modules and functions
https://vsoch.github.io/gridtest/
Mozilla Public License 2.0
2 stars 1 forks source link

adding references to other libraries for grids #35

Closed vsoch closed 4 years ago

vsoch commented 4 years ago

This will add references to several libraries that are intended for grid generation (usually for machine learning) and some description of how they differ from GridTest. This will close #34.

Signed-off-by: vsoch vsochat@stanford.edu

cbrueffer commented 4 years ago

Looks great! The only thing I'd change is adding/using the canonical references for scikit-learn, Keras, and dials, so this counts as proper citations, e.g. https://scikit-learn.org/stable/about.html#citing-scikit-learn

vsoch commented 4 years ago

@cbrueffer so sorry that I missed your comment! Let me fix this right away.

vsoch commented 4 years ago

All set! https://github.com/vsoch/gridtest/pull/35/commits/50a3b1fa074ae75a3a5ac15a19e31ae558242134

cbrueffer commented 4 years ago

Looks good!