Display excursion set rather than statistic map

vsoch / nidmviewer

NIDM Results Viewer

http://vsoch.github.io/nidmviewer/

BSD 3-Clause "New" or "Revised" License

3 stars 3 forks source link

Display excursion set rather than statistic map #11

Open cmaumet opened 8 years ago

cmaumet commented 8 years ago

Note: this PR is based in #10, #10 should be reviewed first.

As suggested by @chrisfilo in #8, this PR update the viewer to display the excursion set map instead of the unthresholded statistic.

vsoch commented 8 years ago

The viewer is doing some strange cropping with the coordinates:

vsoch commented 8 years ago

Here is the exact same ttl file run with the previous version:

vsoch commented 8 years ago

I would remove the column EXC_SET from the table

chrisgorgo commented 8 years ago

Do we need the COORDINATE_ID column? It only clutters the view.

vsoch commented 8 years ago

I agree - I only had it originally assuming it was important for nidm folk.

cmaumet commented 8 years ago

@vsoch: could the "strange cropping" be just an artefact due to the fact that the viewer is at a different location in the brain? This might be related to the fact that the coordinate list is ordered differently between your two screenshots.

cmaumet commented 8 years ago

Not sure why "EXC_SET" is now appearing in the table will have a closer look.

+1 to remove the "COORDINATE_ID" column.

vsoch commented 8 years ago

@chrisfilo @cmaumet see https://github.com/vsoch/nidmviewer/pull/13/files#r65081441