Closed vsoch closed 6 years ago
Thanks for splitting the PRs. Not sure if I am in position to review this, but personally it LGTM
Me as well, merging so I can work on the others.
BTW http://vsoch.github.io/nidmviewer/examples/ is blank in FF 61. Also would be nice to have a link to explanation of what NIDM results
are.
Yes, that's why it wasn't my recommendation to split this apart - the docs reference an example that is added in #24. We can do a separate PR to update the documentation for this - nidmviewer at face value didn't originally educate the user about what nidm results are, and I agree that it should.
Here is the first PR to break apart #24, it should be the easiest of the bunch as it adds only the "soft" changes:
There are no changes to the code. When this PR is reviewed I will work on the next.