search

vsoch / pull-request-action

open a pull request when a branch is pushed or updated
https://github.com/marketplace/actions/pull-request-action
MIT License
174 stars 62 forks source link

replacing set-env with new environment syntax #48

Closed vsoch closed 3 years ago

vsoch commented 4 years ago

This is a suggested fix for the update to not use set-env. We probably don't need to push forward with it until users start gettig issues and have a good example to test with it.

Signed-off-by: vsoch vsochat@stanford.edu

vsoch commented 4 years ago

@AnandChowdhary what do you think about using os.system vs actually deriving that file path in python, opening, and appending to it? I am usually cautious to use os.system.

flxw commented 3 years ago

So, yes we started having issues with it :D Is there anything I can do to help this get merged?

vsoch commented 3 years ago

@david-paulus-saad @AnandChowdhary @flxw I've updated the set_env function to write directly to the file, and rebased with master. Please take another look!

vsoch commented 3 years ago

@david-paulus-saad do you have a link to an action where you tested so I can take a look?

francoisaubert1 commented 3 years ago

I would also be happy to see this one merged, I had to set ACTIONS_ALLOW_UNSECURE_COMMANDS to true to keep my pipelines working. Thank you!

vsoch commented 3 years ago

Thanks everyone! I’ll draft a new release soon.

vsoch commented 3 years ago

https://github.com/vsoch/pull-request-action/releases/tag/1.0.12