search

vsoch / pull-request-action

open a pull request when a branch is pushed or updated
https://github.com/marketplace/actions/pull-request-action
MIT License
174 stars 62 forks source link

PASS_IF_EXISTS option, to not error out when a matching PR already is open #52

Closed tscizzlebg closed 4 years ago

tscizzlebg commented 4 years ago

Added onto vsoch's, by putting the exit code in a different spot.

While in the area, I made the params used for the get different from the data used in the post, since the API signature is slightly different.

Tested it for my use case and it worked (didn't error whether matching PR already existed or not, and created a PR if not).

vsoch commented 4 years ago

That was fast! What do you think about PRing against the branch for the original PR with PASS_IF_EXISTS and then we can merge into a (non master branch) to test as a full action?

tscizzlebg commented 4 years ago

Sure thang

vsoch commented 4 years ago

This looks great! Let's merge here, and then you can test as you did before. Fingers crossed!

tscizzlebg commented 4 years ago

Cool, pointing to vsoch/pull-request-action@add/pr-exists-error worked for my use cases (same 2 cases as before).

vsoch commented 4 years ago

Awesome! Can you share a link to the action so I can take a peek?

tscizzlebg commented 4 years ago

It's a private repo, and due to sensitivity / regulation I think it wouldn't be easy to share :(