search

vsoch / qme

QueueMe is a job queue, manager, and dashboard
https://vsoch.github.io/qme/
Mozilla Public License 2.0
12 stars 4 forks source link

Adding message to run/rerun, other interface tweaks #32

Closed vsoch closed 4 years ago

vsoch commented 4 years ago

This pull request will address the following issues:

vsoch commented 4 years ago

@yarikoptic please review! I tried to just add you as a reviewer to the repo but it didn't give me the option, I suppose I forgot how to do that :P

vsoch commented 4 years ago

Just added QME_MESSAGELEVEL to control the logging level.

yarikoptic commented 4 years ago

Invite me as a collaborator

yarikoptic commented 4 years ago

Consider using common prefix for all env var related to logging, eg shorter QME_LOG_. Then you could uniformly add more settings as needed. I will also appreciate it personally since that is the convention I used in a good number of projects

vsoch commented 4 years ago

Good idea @yarikoptic, but we can add that in a separate PR when there is some refactor of the logger (out of scope here).

vsoch commented 4 years ago

@yarikoptic ready again for review! For the logging I can do that in another PR.

yarikoptic commented 4 years ago

Left a follow up question to one comment which you marked resolved

vsoch commented 4 years ago

Sorry that I missed the bit about the host - it's added now! :)

yarikoptic commented 4 years ago

Sorry to be the pain and not properly describing my intentions, I should have had add a suggestion but ATM hard on the phone.

Before using host variable, don't you need to move it's final definition there? (And use also below), ie

host=host or QME_HOSTNAME

vsoch commented 4 years ago

Oversight on my part - fixed now!