vsoch / scif

scientific filesystem: a filesystem organization for scientific software and metadata
https://sci-f.github.io/
Mozilla Public License 2.0
30 stars 13 forks source link

Fix/client bugs #55

Closed vsoch closed 5 years ago

vsoch commented 5 years ago

This will fix two client bugs:

  1. arguments aren't correctly passed with run.

I've pushed the container vanessa/scif:hw to test this fix, here is an example of arguments being passed correctly:

$ docker run -it vanessa/scif:hw run hello-world-custom THINGONE
[hello-world-custom] executing /bin/bash /scif/apps/hello-world-custom/scif/runscript THINGONE
Hello THINGONE

$ docker run -it vanessa/scif:hw run hello-world-custom THINGONE THINGTWO
[hello-world-custom] executing /bin/bash /scif/apps/hello-world-custom/scif/runscript THINGONE THINGTWO
Hello THINGONE THINGTWO

$ docker run -it vanessa/scif:hw run hello-world-custom THINGONE THINGTWO --omg
[hello-world-custom] executing /bin/bash /scif/apps/hello-world-custom/scif/runscript THINGONE THINGTWO --omg
Hello THINGONE THINGTWO --omg
  1. The next issue is that exec was hitting the runscript (instead of executing the command). Here is the fixed example:
$ docker run vanessa/scif:hw exec hello-world-env echo "Meatballs"
[hello-world-env] executing /bin/echo Meatballs
Meatballs

In addition, I've updated the date in the headers.

This will close #54 #53

vsoch commented 5 years ago

Note: just changed so that if there is no runscript, it alerts the user and exits.

vsoch commented 5 years ago

okay cool! I tested most bits so I'm good to merge. Please open another issue if you run into any more, and always glad to help :) I'll release this on pypi in a minute and post the link here.

vsoch commented 5 years ago

https://pypi.org/project/scif/0.0.77/