search

vsoch / scif

scientific filesystem: a filesystem organization for scientific software and metadata
https://sci-f.github.io/
Mozilla Public License 2.0
30 stars 13 forks source link

fix shell behavior #61

Closed samcmill closed 4 years ago

samcmill commented 4 years ago

This PR fixes 2 shell related issues.

First, an extra /bin/bash gets appended to the shell entrypoint:

$ scif shell ref
[ref] executing /bin/bash /bin/bash
/bin/bash: /bin/bash: cannot execute binary file

This is fixed by checking whether args is defined in activate().

Second, the documentation says If an app doesn’t have an %apprun section, we default to a shell. However, this case is treated as an error:

$ scif run ref 
ERROR ref does not have a runscript.

This is fixed by converting this message from an error to a debug statement. Also correctly sets the resulting shell as interactive.

vsoch commented 4 years ago

Thanks @samcmill ! Should be on pypi now https://pypi.org/project/scif/0.0.79/. I'll need to fix the docs rendering there to be markdown, will go into next release.