scif install should return error exit code on error during appinstall

[bilke]

When something goes wrong in the %appinstall section the corresponding scif install ..-call returns 0 which means success. Would it be possible to check for errors and return a proper error value?

[vsoch]

This would definitely be wanted! Could you please provide the scif recipe / container so that I can reproduce your issue, and work on it further?

[bilke]

At the moment I do not have a scif recipe at hand but something like this:

...
%appinstall
return 0       # this is fine
return 1       # this should stop `scif install` and should also return maybe 1 as the `scif install`-exit code
return 0       # will not be reached in this case
....

[vsoch]

All set! https://github.com/vsoch/scif/pull/66. Would you care to test? Take a look in docs/examples, I added subfolders there (and the first is to test this use case).

[bilke]

Thanks a lot Vanessa! I will test thoroughly tomorrow!

[vsoch]

sounds good :) Happy MLK!

[vsoch]

Actually I'm not sure you have that holiday... so instead, how about have a good evening! And have a party too, if you feel like it :tada: :O)