search

vsoch / scif

scientific filesystem: a filesystem organization for scientific software and metadata
https://sci-f.github.io/
Mozilla Public License 2.0
30 stars 12 forks source link

exit with the exit code from a app when run() #68

Closed dmachi closed 8 months ago

dmachi commented 8 months ago

This patch makes the run() command exit with the same exit code as the app being run. It is a straight forward update. I have created an apptainer test following the pattern used for "exit-on-install", though mine builds a apptainer/singularity image instead of a docker image as I don't have an easy place to run as docker at the moment. This patch includes updating the CHANGELOG and the version of the package, however it was not clear to me from the contributing guidelines whether I should update the version or not. If you'd like me to back any of that out, please let me know. I also didnt' see a "development" branch for the merge, so this PR is against master.

vsoch commented 8 months ago

@dmachi this is a black formatting issue unrelated to your work. Would you like me to push a fixed PR with formatting, or do you want to run it here alongside your work? Either works for me, I can still review with the extra noise. And note the CI is installing black==23.11.0. We could pin that version as well, but I'm good either way.

dmachi commented 8 months ago

@vsoch, thanks. If you can push a fixed PR with formatting that'd be great. I'd do it myself, but its not clear to me what I need to do.

vsoch commented 8 months ago

okay all set - you should be able to rebase on master now.

dmachi commented 8 months ago

Thanks, I've merged these changes back into my fork. Do you need me to do anything else on this PR?

vsoch commented 8 months ago

Thank you @dmachi ! https://pypi.org/project/scif/0.0.82/