search

vsoch / scif

scientific filesystem: a filesystem organization for scientific software and metadata
https://sci-f.github.io/
Mozilla Public License 2.0
30 stars 12 forks source link

Reworked app.run exit code #73

Closed dmachi closed 8 months ago

dmachi commented 8 months ago

Here is a new version of the same app.run exit code work. I added a new app to the hello-world scif and used it for tests in test_run. I also added a test for shell substitution issue that @dtrudg reported from my previous PR. This patch includes updates to the changelog and the scif/version.py to bump the version 0.0.84.

vsoch commented 8 months ago

This looks good to me - a very simple change to get the desired functionality, and with a test. @dtrudg do you approve as well?

vsoch commented 8 months ago

Alright - time for a take 2!