vsphere-tmm / helm-charts

A repository of unofficial helm charts for vSphere components
https://vsphere-tmm.github.io/helm-charts/
21 stars 27 forks source link

vsphere-csi-snapshotwebhook pods doesnt become available #43

Closed ilpozzd closed 2 years ago

ilpozzd commented 2 years ago

vsphere-csi-snapshotwebhook pods doesnt become available with error:

MountVolume.SetUp failed for volume "webhook-certs" : secret "vsphere-csi-webhook-certs" not found

I found secret with vsphere-csi-snapshot-webhook-certs name. Is it mismatch?

Chart version: 2.1.1 Kubernetes version: 1.23.6

ilpozzd commented 2 years ago

@mylesagray #42 should fix this

kfox1111 commented 2 years ago

This chart seems to have its own definitions for the webhook. But there is a semiofficial upstream chart for both the webhook and the controller. Would it be better to remove the existing webhook support instead of fixing it and then conditionally including the webhook and the controller?

Repo: https://piraeus.io/helm-charts/

For example:

  chart: piraeus-charts/snapshot-controller
  version: 1.2.1
  chart: piraeus-charts/snapshot-validation-webhook
  version: 1.2.1
kfox1111 commented 2 years ago

Actually, you can't turn it off without disabling snaphots entirely. This is problematic if you have non vmware drivers on the same cluster,

kfox1111 commented 2 years ago

Should I open a new ticket for the issues I've raised here?