If controller.config.block-volume-snapshot is disabled, several snapshotting components (e.g. the snapshot-validation-webhook) will be disabled and not deployed. The csi-snapshotter container will still be deployed via the controller deployment. In my case this resulted in this error:
CSI driver [csi.vsphere.vmware.com](http://csi.vsphere.vmware.com/) does not support ControllerCreateSnapshot
After having a look at the Snapshot feature and the official documentation, it looks like this is just patched in if you deploy the snapshot feature (Source). I think the csi-snapshotter can be removed completely.
Possible Solution
I've created a PR adding a conditional to the chart, that disables the csi-snapshotter container if controller.config.block-volume-snapshot is disabled.
Problem
If
controller.config.block-volume-snapshot
is disabled, several snapshotting components (e.g. the snapshot-validation-webhook) will be disabled and not deployed. The csi-snapshotter container will still be deployed via the controller deployment. In my case this resulted in this error:After having a look at the Snapshot feature and the official documentation, it looks like this is just patched in if you deploy the snapshot feature (Source). I think the csi-snapshotter can be removed completely.
Possible Solution
I've created a PR adding a conditional to the chart, that disables the csi-snapshotter container if
controller.config.block-volume-snapshot
is disabled.