search

vsphere-tmm / helm-charts

A repository of unofficial helm charts for vSphere components
https://vsphere-tmm.github.io/helm-charts/
21 stars 27 forks source link

feat: remove default nodeSelector and tolerations from values file #65

Closed fad3t closed 9 months ago

fad3t commented 1 year ago

Hello!

First of all thanks for making those charts, they're very helpful to the community!

I would like to propose an improvement about the scheduling of the CSI controller. For now it is only schedulable on control plane nodes, but in our case we're making use of dedicated infrastructure nodes whose role is to run those kind of controllers.

I've tried adding a nodeSelector and tolerations -- however the nodeSelector being a map, the key for the control plane never gets deleted -- and the controller pod remains in Pending state forever. Ideally we would need to rely only on nodeSelector and tolerations provided by the user when they're provided, otherwise use the defaults you guys have setup -- but not a mix of both.

I hope my intend is clear, let me know if you have any remarks.

Fred

fad3t commented 10 months ago

Hello, Any chance this gets reviewed and merged? Thanks!

MaxRink commented 10 months ago

Hi, what you want can already be achieved by just setting the map to 'null'/ the list to empty

so 

controller:
  nodeSelector: null
  tolerations: []

will give you your desired outcome

fad3t commented 10 months ago

Hi @MaxRink,

I don't think so. I'm trying to run the controller on a specific node group. If I remove the nodeSelector completely (by setting it to null), the controller may be scheduled on any node, which is not what I want.

On the other hand, if I set the nodeSelector to match my node group, the control-plane key gets added to the map, and the pod never gets scheduled (because my node group isn't running the control plane).

Thx

MaxRink commented 9 months ago

hey, sorry for taking so long to respond, was on PTO :S And yes, i see your point.