search

vsphere-tmm / helm-charts

A repository of unofficial helm charts for vSphere components
https://vsphere-tmm.github.io/helm-charts/
21 stars 27 forks source link

DaemonSet updateStrategy #66

Closed jda258 closed 9 months ago

jda258 commented 11 months ago

Hello,

Is there a reason for this DaemonSet updateStrategy:

  updateStrategy:
    rollingUpdate:
      maxSurge: 0
      maxUnavailable: 1
    type: RollingUpdate

These settings make it take a long time to update for larger clusters. Is there a better default setting, or should it be added to the values file?

Thanks, Josh

jda258 commented 11 months ago

The update strategy is variabilized, just not documented: https://github.com/vsphere-tmm/helm-charts/blob/master/charts/vsphere-csi/templates/node/daemonset-linux.yaml#L16C1-L19C12

MaxRink commented 9 months ago

https://github.com/vsphere-tmm/helm-charts/pull/71 adds it to the readme