vsphere-tmm / helm-charts

A repository of unofficial helm charts for vSphere components
https://vsphere-tmm.github.io/helm-charts/
21 stars 27 forks source link

Moving hardcoded nodeSelector of node/daemonset-linux to helm function, making node.nodeSelector usable #84

Closed druesendieb closed 2 months ago

druesendieb commented 2 months ago

Description

This PR makes node.nodeSelector usable again by moving the hardcoded nodeSelector of daemonset-linux.yaml to the node.nodeSelector function.

Issue

If node.nodeSelector is currently set, the produced templated yaml contains 2 nodeSelector entries, resulting in errors during apply.

After using helm template and applying the result, we got this following error:

Error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 64: mapping key "nodeSelector" already defined at line 44
error: no objects passed to apply
MaxRink commented 2 months ago

Hi, can you also bump the version in the chart yaml? Merging will then trigger an automatic release

druesendieb commented 2 months ago

Done.