Open vsriram77 opened 11 years ago
Looks good! The way you used the segmented buttons is a little bit unusual, but that's more UI feedback rather than technical feedback.
Other feedback:
- (float) convertFahrenheitToCelsius: (float) input;
, use something like - (float)fahrenheitWithCelsius:(float)celsius
.Thanks Tim!
I was inspired by the Google web search shortcut for metric conversion: for e.g. google search "fahrenheit to celsius", but didn't follow its example through entirely..
Thanks for the feedback..
-Sriram
From: Timothy Lee notifications@github.com To: vsriram77/itempconv itempconv@noreply.github.com Cc: vsriram77 v_sram@yahoo.com Sent: Sunday, July 28, 2013 9:31 PM Subject: Re: [itempconv] ios temperature converter (#1)
Looks good! The way you used the segmented buttons is a little bit unusual, but that's more UI feedback rather than technical feedback. Other feedback: * All methods should be private unless they are used outside of the class. You have a few public methods that should be private methods. * Instead of method names like - (float) convertFahrenheitToCelsius: (float) input;, use something like - (float)fahrenheitWithCelsius:(float)celsius. — Reply to this email directly or view it on GitHub.
/cc @nesquena @timothy1ee