vstinner / hachoir

Hachoir is a Python library to view and edit a binary stream field by field
http://hachoir.readthedocs.io/
GNU General Public License v2.0
604 stars 70 forks source link

Improve OpenType/TrueType support #63

Closed simoncozens closed 3 years ago

simoncozens commented 3 years ago

This PR:

simoncozens commented 3 years ago

Good idea; I will get to it.

vstinner commented 3 years ago

Please fix tox -e pep8 errors:

 hachoir/parser/misc/ttf.py:340:5: F841 local variable 'start' is assigned to but never used
hachoir/parser/misc/ttf.py:404:18: F821 undefined name 'er'
hachoir/parser/misc/ttf.py:405:12: F821 undefined name 'last'
hachoir/parser/misc/ttf.py:405:21: F821 undefined name 'last'
hachoir/parser/misc/ttf.py:407:9: F841 local variable 'last' is assigned to but never used
hachoir/parser/misc/ttf.py:637:39: F821 undefined name 'parseFeatureVariationsTable'
ERROR: InvocationError for command /usr/bin/sh tools/flake8.sh (exited with code 1)
simoncozens commented 3 years ago

I think this is done now, with a few more fixes in there and another table for good measure.

vstinner commented 3 years ago

Merged, thanks.