search

vstinner / hachoir

Hachoir is a Python library to view and edit a binary stream field by field
http://hachoir.readthedocs.io/
GNU General Public License v2.0
604 stars 70 forks source link

CabFile extraction produces corrupt files in some cases #76

Closed brechtm closed 2 years ago

brechtm commented 2 years ago

@nneonneo Sorry to bother you again, but for verdan32.exe, two of the extracted TTF files differ in 1 (Verdanai.TTF) or 2 bytes (Verdanab.TTF) at position 0x56 from those extracted by cabextract.

The other core font installers seems to extract fine, but I haven't verified all files.

nneonneo commented 2 years ago

@brechtm ok, the PR should fix the issue - please feel free to test it.

brechtm commented 2 years ago

Thanks @nneonneo! I verified all font files in each of the core font installers. All are identical to the cabextracted files 👍

brechtm commented 2 years ago

Can I bug you again to release 3.1.4 with this fix? 😁

brechtm commented 2 years ago

@nneonneo @vstinner Just another careful request to make another release. Just so, in case you can't find the time, I know I need to work around it. Cheers!