search

vstirbu / InstagramPlugin

Instagram plugin for PhoneGap/Cordova
MIT License
120 stars 78 forks source link

Fix sharing on iOS #112

Closed LucWollants closed 4 years ago

LucWollants commented 5 years ago

Fixed

jk90-obi commented 5 years ago

This works, can we have someone with write access to the repo to review & approve PR?

roxteddy commented 5 years ago

So the igo extension is not registered by Instagram on iOS anymore ?

LucWollants commented 4 years ago

If igo is used Instagram is no longer shown on the Share Sheet.

rodrigograca31 commented 4 years ago

@LucWollants question: doesnt this break for older iOS versions?

or actually for older Instagram versions? meaning seems Intagram changed their "package id" and only those who updated Instagram will have the new "package id"

LucWollants commented 4 years ago

question: doesnt this break for older iOS versions?

or actually for older Instagram versions? meaning seems Intagram changed their "package id" and only those who updated Instagram will have the new "package id"

I did not test this, shame on me. But if that would be the case it makes sense to make this configurable?

rodrigograca31 commented 4 years ago

I wouldn't say configurable but a test for the version would be nice. I know Apple is better than Android keeping devices updated I just dont know how many will install the apps in older iOS versions and it wont work for them. (I'm not in the Apple ecosystem/stuff)

According to this "random site": https://david-smith.org/iosversionstats/ iOS 13 is at 92% overall so I guess thats very good. (I wish Android was like this :cry:)

I will accept this PR and release a patch version of this plugin. Ok?

LucWollants commented 4 years ago

I wouldn't say configurable but a test for the version would be nice.

You mean testing the iOS version or the Instagram version (not sure this can be done)?

rodrigograca31 commented 4 years ago

I wouldn't say configurable but a test for the version would be nice.

You mean testing the iOS version or the Instagram version (not sure this can be done)?

I dont know enoguht iOS to answer but I read that as of iOS 13 that changed so I'd test for the iOS version but from what I know from Android thats not a OS thing, its the instagram app that is registering a "endpoint name" that you can use right?

rodrigograca31 commented 4 years ago

Ooops I acidentally closed the PR.... now doesnt let me reopen.... says the original repo was deleted....

Can you re open @LucWollants ? sorry.

LucWollants commented 4 years ago

Can you re open

I don't have the rights to do this on this repo. The original PR is from a deleted repo I neither have access rights on. So best to create a new fork and re-apply the changes and point to this PR.

rodrigograca31 commented 4 years ago

Ok. I will make a new PR and link to this one to give credits.

but can you answer my previous question?

was this change (igo to ig and etc) an iOS 13 change or Instagram one?

rodrigograca31 commented 4 years ago

Actually seems the answer is here:

https://github.com/vstirbu/InstagramPlugin/pull/106/commits/8988811d617c7ad3a2a8fa1ad7bb8dfe9a685b79 and https://github.com/vstirbu/InstagramPlugin/pull/106/commits/4ce60cc3199e1b00bb2a1543994d94b8104b0ba8 and https://github.com/vstirbu/InstagramPlugin/pull/106/commits/b2f66119720b152869ea8aeec764f4100724570f

do you guys agree that I should apply these 3 commits?

rodrigograca31 commented 4 years ago

Im coming back to this issue now.

I will manually perform this changes and push to a new branch.