vstoykov / django-clamd

Integrates python-clamd with Django for easy scanning files for viruses on upload
17 stars 33 forks source link

Validator 'fails open' when file is too large to process #11

Closed KyeRussell closed 11 months ago

KyeRussell commented 4 years ago

My understanding of this:

https://github.com/vstoykov/django-clamd/blob/master/src/django_clamd/validators.py#L28

Is that validation will pass if Clam cannot process the file (ostensibly due to size). Does this not mean that I'd just need a very large virus? Would it be better to fail closed, or at least provide an option to do so?

Happy to implement this if desired.