Crashes other styles with 1.5.1

vsymguysung / ember-cli-summernote

ember cli addon for summernote

MIT License

31 stars 22 forks source link

Crashes other styles with 1.5.1 #35

Open bmaehr opened 5 years ago

bmaehr commented 5 years ago

Hello,

It is nice to see, that bower seems to be not needed anymore by 1.5.1.

But unfortunately version 1.5.1 crashes styles of other components / the app. For example the global style a:not([href]):not([tabindex]) changes the color of some buttons and links.

An other effect was, that a vertical list of menu items in ribbon style was collapsed to a smaller space.

So please check your style changes and apply them only for your component and not globally.

vsymguysung commented 5 years ago

Could you be more detail on the issue ? It would be awesome that you could make a PR for it considering I am pretty much occupied with other projects at work these days.

bmaehr commented 5 years ago

I think the problem is, that you added "bootstrap": "^4.0.0-beta" as a dependency. The problem seams to be described in https://github.com/twbs/bootstrap/issues/24140