search

vt-elixir / ja_serializer

JSONAPI.org Serialization in Elixir.
Other
640 stars 148 forks source link

Making some of JaSerializer.Builder.TopLevel public? #284

Closed john-griffin closed 5 years ago

john-griffin commented 6 years ago

In our app we have copied over the following function implementations from JaSerializer.Builder.TopLevel:

normalize_includes
normalize_relationship_path_list
normalize_relationship_path
deep_merge_relationship_paths

We are calling normalize_includes to assist in building a preload query that we pass to ecto. Would it possible to make this function public so that we don't need to copy the code over? It might need to be moved out of builder to make more sense as a public API but I'm not 100%.

cc @beerlington