search

vt-elixir / ja_serializer

JSONAPI.org Serialization in Elixir.
Other
640 stars 148 forks source link

Handle the case where the end of a link is a URI fragment e.g. /foo#path #293

Closed AlexRiedler closed 5 years ago

AlexRiedler commented 6 years ago

The existing code would add a random question mark '?' inbetween producing "/foo?#path" this is unnecessary and should become "/foo#path". Instead of using a regex to remove, lets just not set it on the URI if the query parameter is nil.

beerlington commented 5 years ago

@AlexRiedler I'm finally getting around to reviewing all the existing PRs and this looks good. I pushed an update to master last night that formats the code using mix format so this will need to be rebased. If you're able to resolve the merge conflicts, I can get this merged in.

AlexRiedler commented 5 years ago

@beerlington thanks! I have rebased the changes :)

beerlington commented 5 years ago

Thanks!