vt-elixir / ja_serializer

JSONAPI.org Serialization in Elixir.
Other
640 stars 148 forks source link

Removes JaSerializer Phoenix generators #325

Closed beerlington closed 5 years ago

beerlington commented 5 years ago

These were a pain to test and maintain and were not easily upgraded with new versions of Phoenix. By instead guiding users to start with a Phoenix generator instead, they will be starting with code that is guaranteed to work.

Closes #149 Closes #186 Closes #220

beerlington commented 5 years ago

@alanpeabody any objections? I personally don't use generators because I never like the code they generate and I don't feel like they encourage developers to learn how things work. For people who like generators, I did put together a Wiki page that shows how to start with the Phoenix generator and update the code to work with JaSerializer.

alanpeabody commented 5 years ago

None at all - if anything they should be maintained independently if people really want them.