vt-middleware / cryptacular

The friendly complement to the BouncyCastle crypto API for Java.
Other
39 stars 7 forks source link

Allows for specifying test verbosity via Maven #28

Closed ememisya closed 8 years ago

ememisya commented 8 years ago

ex: mvn -Dverbosity=10 test See: Level of Verbosity at https://maven.apache.org/surefire/maven-surefire-plugin/examples/testng.html

serac commented 8 years ago

Can you explain the rationale for this property? Do you want more or less test output?

ememisya commented 8 years ago

The default characteristic of the test goal seems to be no output except the results of the tests after they have been performed. I wanted the ability to see the tests as they are being executed and with which certificates and so on, which lead me to testng's verbosity feature. By implementing the property we can still keep the current behaviour until the developer specifies the verbosity parameter between 1-10 depending on the level of information they wish to see during testing.

serac commented 8 years ago

Understood, thanks. I think this is a beneficial change, though I might want to see it driven by a profile instead of a property. It should default to a reasonable value (0?) such that it's not required to be set on the command line. A profile is one straightforward way to accomplish that.

dfish3r commented 8 years ago

It doesn't bother me if it remains a property, but it should have a more descriptive name. Like ${testng.verbosity}

serac commented 8 years ago

My only requirement is that it's not necessary to specify -Dproperty.name=X on the command line to build.