Issue 31+32 - Githubissues

vt-middleware / cryptacular

The friendly complement to the BouncyCastle crypto API for Java.

Other

39 stars 7 forks source link

Issue 31+32 #33

Closed ememisya closed 1 year ago

ememisya commented 8 years ago

What's New?

Refactored asn package to decoder (as it does more than ASN now)
Added decoder for SSH2 RSA & DSA public keys (RFC-4253)
Added PemReader which validates and parses PEMs based on their respective RFCs
New utils to help with the features above

ememisya commented 8 years ago

Given there are API changes (major release), would you like for me to refactor so that I add the decoder package and leave asn alone for now, and perhaps we deprecate it and merge in the next major version release? Or would you rather we wait to merge this into the next major release? Or perhaps this merits a new major release?

serac commented 8 years ago

Looks good generally, but I'm concerned about moving existing components from the asn package to decoder. I don't think these changes merit a major version bump, so let's go with duplicating and deprecating for now.

ememisya commented 8 years ago

Pushed a4dfda3 with the changes.

ememisya commented 8 years ago

Pushed 4b09660 and dae85ea with the changes discussed.

ememisya commented 7 years ago

Any update on this? It's been a while :smile:

serac commented 7 years ago

I have a slight concern about effectively changing package names, but I think we've handled it fairly well via deprecation. I think that's relatively low cost for the functionality we get. @dfish3r do you have any concerns about accepting this work? I'm inclined to accept it. If you agree, I'll squash it down into a single commit and merge offline.

ememisya commented 6 years ago

Hi @dfish3r, just checking in on this branch. Any plans to move forward with the work?

ememisya commented 5 years ago

Hey guys, any news on this? Looks like it hasn't strayed far behind despite the time elapsed.

ememisya commented 6 months ago

So why wasn't this implemented?