search

vt-middleware / cryptacular

The friendly complement to the BouncyCastle crypto API for Java.
Other
39 stars 7 forks source link

fix #69-ssh-pubkey-pem #70

Closed ememisya closed 6 months ago

ememisya commented 6 months ago

PR request for the issue mentioned regarding .pub and .pem files containing SSH related public keys.

ememisya commented 6 months ago

I noticed I had removed some of the static final String fields from PemUtil, I went back and added Deprecated over them so that japicmp doesn't fail and did some additional re-factorization. Hopefully it is acceptable :)

serac commented 6 months ago

This is a useful feature that I'm inclined to accept, though possibly with some changes. I was a little offput at the introduction of new component interfaces, but upon further reflection I think they make sense. I will have to review more carefully, but I believe that aspect is acceptable as it is. There are some implementation points that I'd also like to consider more carefully; if I end up pursuing meaningful implementation changes, I'll likely just base a branch off yours here and create a new PR from it to move forward. I'll try to provide an update by the end of the week.

serac commented 6 months ago

Closing in favor of #73. Just some minor implementation tweaks and Javadoc cleanup.