Alternate implementation w/multiple error codes.

vt-middleware / passay

Password policy enforcement for Java.

http://www.passay.org

Other

281 stars 64 forks source link

Alternate implementation w/multiple error codes. #111

Closed serac closed 4 years ago

dfish3r commented 4 years ago

Not API compatible.

***! MODIFIED CLASS: PUBLIC org.passay.RuleResultDetail  (not serializable)
        ===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
        ---! REMOVED FIELD: PROTECTED(-) FINAL(-) java.lang.String errorCode

serac commented 4 years ago

Addressed code review feedback. I can't comment on your API incompatible feedback. It's obviously API compatible in this sense of it has the same public API, but maybe you mean it ABI incompatible, which I can see. That doesn't seem like an issue, but you know more about this than I do so I defer to your judgement.

dfish3r commented 4 years ago

I've seen this called 'API Binary Compatibility'. Whatever it's called, it means you don't have to recompile your code to use the next revision of library. Which is not the case here. This change bumps the version to 1.6.0, can you update the pom in this PR?

serac commented 4 years ago

Bumped version