vt-middleware / passay

Password policy enforcement for Java.
http://www.passay.org
Other
277 stars 63 forks source link

Consider removing DictionaryBuilder #97

Open amichair opened 5 years ago

amichair commented 5 years ago

I'm not sure there is need for an entire class just to set two fields and call a utility method with the two fields as parameters... One can just call the utility method (WordLists.createFromReader) directly. If necessary, overloaded WordLists methods can be added to handle strings instead of readers, use varargs for multiple inputs, use a default sorter, or whatever else might be convenient, but splitting this functionality into two different places (WordLists and DictionaryBuilder) seems a bit off. It's worth revisiting this design imho. Of course it can be deprecated first and removed in the future to ease the migration.