search

vt-middleware / passay

Password policy enforcement for Java.
http://www.passay.org
Other
282 stars 64 forks source link

Fix NoSuchMethodErrors using Buffer when compiling on JDK9+ #98

Closed amichair closed 5 years ago

amichair commented 5 years ago

and running on JDK 8.

I see you just reverted the JDK upgrade due to these Buffer API changes causing trouble... I hope this fixes it and you can proceed with the upgrade. Would be a shame to be stuck on JDK8...

btw, to recreate the issue without this fix, build (mvn clean install) using JDK 9+ (just specify a JAVA_HOME pointing to it), and then run the tests without compiling (mvn surefire:test) using JDK8.

amichair commented 5 years ago

btw, why isn't github running the travis build on every push? I guess it needs to be set up.

dfish3r commented 5 years ago

The travis build only runs against master.

dfish3r commented 5 years ago

Thanks for this patch. I'll test it against our Java8 projects shortly.