search

vtalbot / markdown

Markdown compiler for Laravel 4 and 5
100 stars 24 forks source link

Update unit tests and support modern Laravel #28

Closed heathdutton closed 3 years ago

heathdutton commented 4 years ago

I have some legacy projects still using this, but they couldn't be upgraded to Laravel 6 as a result. This should get us over the hurdle.

Continues & replaces #22

vtalbot commented 4 years ago

Just tell me when you consider it ready to be merge.

nonoesp commented 4 years ago

@heathdutton this is super useful — thanks for your work!

vtalbot commented 4 years ago

@heathdutton Before I merge it, do you want to add more stuff?

heathdutton commented 4 years ago

I have nothing more to merge at the moment. But haven't had time to test this much either.

heathdutton commented 4 years ago

Just discovered the route that is added by default. That's not cacheable because it uses a closure... That should be refactored to use a controller. For me I'm just disabling the routes since I don't need it, but if someone wants to follow up with that :)...

heathdutton commented 3 years ago

Ready to merge.

nonoesp commented 3 years ago

This is great - thanks! 🥳