vterron / lemon

Differential photometry for humans (and astronomers)
64 stars 21 forks source link

Annuli not working #85

Closed wschoenell closed 8 years ago

wschoenell commented 8 years ago

When I run lemon annuli I get the error below. It tries to run lemon diffphot with a --output option when this option does not exists. I am able to fix this problem doing this: https://github.com/vterron/lemon/compare/vterron:2585cd0...wschoenell:f8b9402

Williams-MacBook-Pro-2:reduced william$ ~/workspace/lemon/lemon annuli --gain=1.5 lemon_out/HATS-P-7-*fits lemon_out/HATS-P-7.json
>> Examining the headers of the 172 FITS files given as input...
>> 100%[======================================================================>]
>> 
>> Doing initial photometry with FWHM-derived apertures...
>> 
>> Examining the headers of the 172 FITS files given as input...
>> 100%[======================================================================>]
>> 1 different photometric filters were detected:
>>  V: 172 files (100.00 %)
>> Making sure there are no images with the same date and filter... done.
>> Sources image: lemon_out/HATS-P-7-001a.fits
>> Running SExtractor on the sources image... done.
>> Calculating coordinates of field center... done.
>> α = 208.8561276  (13 55 25.47)
>> δ = -21.2102722 (-21 12 36.98)
>> Detected 14808 sources on which to do photometry.
>> 
>> Need to determine the instrumental magnitude of each source.
>> Doing photometry on the sources image, using the parameters:
>> FWHM (sources image) = 1.090 pixels, therefore:
>> Aperture radius = 1.090 x 3.00 = 3.270 pixels
>> Sky annulus, inner radius = 1.090 x 4.50 = 4.905 pixels
>> Sky annulus, width = 1.090 x 1.00 = 1.090 pixels
>> Whoops! Sky annulus too thin, setting it to the minimum of 3.00 pixels
>> 
>> Running IRAF's qphot... done.
>> Detecting INDEF objects... done.
>> 3131 objects are INDEF in the sources image.
>> There are 11677 objects left on which to do photometry.
>> Making sure INDEF objects were removed... done.
>> 
>> Initializing output LEMONdB... done.
>> 
>> Let's do photometry on the 172 images taken in the V filter.
>> Calculating the median FWHM for this filter... done.
>> FWHM (V) = 1.146 pixels, therefore:
>> Aperture radius = 1.146 x 3.00 = 3.438 pixels
>> Sky annulus, inner radius = 1.146 x 4.50 = 5.157 pixels
>> Sky annulus, width = 1.146 x 1.00 = 1.146 pixels
>> Whoops! Sky annulus too thin, setting it to the minimum of 3.00 pixels
>> 100%[======================================================================>]
>> Storing photometric measurements in the database...
>> 100%[======================================================================>]
>> Gathering statistics about tables and indexes... done.
>> You're done ^_^
>> 
>> Generating light curves for initial photometry.
>> 
Usage: lemon annuli [OPTION]... INPUT_DB OUTPUT_DB

lemon annuli: error: no such option: --output
vterron commented 8 years ago

My apologies: annuli stopped working long ago and should have already been removed. It was never a good idea and the whole concept of automatically determining the optimal parameters for aperture photometry was merely more than a rudimentary proof-of-concept — if only it were that easy.

I'm opening an issue as a reminder to exterminate the command as soon as I resume the development of the pipeline.

wschoenell commented 8 years ago

Thanks! Is there another module with proof of concept status that should be not used?

vterron commented 8 years ago

No, that's the only one! Although if you take a look at the list of commands you can see that they are divided into two categories: essential and auxiliary. The latter are scripts that have proved useful in the past and may be of help to other people, but that do not necessarily belong in a pipeline for differential photometry whose sole purpose is to generate light curves:

vterron@iaa:~$ lemon
usage: lemon [--help] [--version] [--update] COMMAND [ARGS]

The essential commands are:
   astrometry   Calibrate the images astrometrically
   mosaic       Assemble the images into a mosaic
   photometry   Perform aperture photometry
   diffphot     Generate light curves
   juicer       LEMONdB browser and variability analyzer

The auxiliary, not-always-necessary commands are:
   import       Group the images of an observing campaign
   seeing       Discard images with bad seeing or elongated
   annuli       Find optimal parameters for photometry

See 'lemon COMMAND' for more information on a specific command.

It might be the case that these auxiliary commands will change or be removed in the future, but the essential ones are expected and pretty much guaranteed to remain the same.

wschoenell commented 8 years ago

Thanks @vterron!

On Fri, May 20, 2016 at 3:48 AM Víctor Terrón notifications@github.com wrote:

No, that's the only one! Although if you take a look at the list of commands you can see that they are divided into two categories: essential and auxiliary. The latter are scripts that have proved useful in the past and may be of help to other people, but that do not necessarily belong in a pipeline for differential photometry whose sole purpose is to generate light curves:

vterron@iaa:~$ lemon usage: lemon [--help] [--version] [--update] COMMAND [ARGS]

The essential commands are: astrometry Calibrate the images astrometrically mosaic Assemble the images into a mosaic photometry Perform aperture photometry diffphot Generate light curves juicer LEMONdB browser and variability analyzer

The auxiliary, not-always-necessary commands are: import Group the images of an observing campaign seeing Discard images with bad seeing or elongated annuli Find optimal parameters for photometry

See 'lemon COMMAND' for more information on a specific command.

It might be the case that these auxiliary commands will change or be removed in the future, but the essential ones are expected and pretty much guaranteed to remain the same.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/vterron/lemon/issues/85#issuecomment-220530481

vterron commented 8 years ago

You're welcome, @wschoenell!