vtex-apps / address-locator

VTEX address locator app to delivery store
3 stars 5 forks source link

No documentation on how to declare blocks #48

Open Git-the-Sanz opened 3 years ago

Git-the-Sanz commented 3 years ago

Describe the bug Looks like the store-framework implementation is outdated. interfaces.json declares a custom page as store.address and there’s no documentation in how to implement the required blocks for this app to function properly.

Also, the React code seems that it does a check if a ‘modal’ is open, does this use ‘modal-layout’?

Lastly, without the proper steps on how to implement all blocks, you will fall in a redirect. This is due to the wrapper passing a function to its child components which provokes a redirection when the OrderForm is updated && the ‘modal’ is still open.

To Reproduce

  1. Declare, anywhere, address-manager
  2. Try to use the search address functionality
  3. You’ll enter in a permanent redirect

Screenshots

Screen Shot 2020-12-22 at 21 32 57
Screen Shot 2020-12-22 at 21 33 24

Apps should NOT be publicly published without proper documentation.