search

vtex-apps / address-locator

VTEX address locator app to delivery store
3 stars 5 forks source link

Fix CSS classes #5

Open hapoza opened 6 years ago

hapoza commented 6 years ago

CSS classes are being used inconsistently all over, all classes need to be prefixed with vtex-.

brianabaker commented 6 years ago

Hi everything i see in global.css is prefixed with vtex- and I only notice that the following span class has items that aren't prefixed with vtex-: absolute bottom-0 pv4 left-1 vtex-input-icon vtex-input-icon--brazil

Do you want absolute, bottom, pv4, and left to be prefixed by vtex-?

hapoza commented 6 years ago

Sorry, I should have referenced that this is about a Pull Request that's yet to be merged. I just created the issue as a reminder to do that in the future once the main functionality is shipped and I can focus on improving code style and other minor nitpicks.

brianabaker commented 6 years ago

Got it! I'll let you do your thing :)